-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SM Cipher certificate test header: certs_test_sm.h #6825
Conversation
retest this please |
retest this please Jenkins |
fails test for special characters found
|
cleaned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the addition of certs_test_sm.h but thinking on it more, should it go into the wolfsm repository and get added to wolfssl with the wolfsm/install.sh script?
@@ -0,0 +1,8400 @@ | |||
/* certs_test_sm.h */ | |||
/* This file was generated using: ./gencertbuf_sm.pl */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was gencertbuf_sm.pl supposed to be in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see #6681 although the correct name is gencert_sm.sh and needs to be cleaned up.
@JacobBarthelmeh : yes, good catch. I agree the certs should be copied with SM install instead. I'll be creating a new PR over there in |
@JacobBarthelmeh would you like me to also move the certs/sm2 files to wolfSSL/wolfsm as well & include in the respective install.sh? cc: @SparkiDev |
I'm planning to instead update existing |
I'm closing this lingering PR. I'd still like to do this at some point. I've added this to my Mothball section in #6234 |
Description
This update adds the
certs_test_sm.h
file: the SM Cipher specific certs in array format, partially addressing #6681.Contents were semi-manually generated using gencertbuf.pl. I still need to create a script to automatically refresh it.
I'm in the process of polishing my Espressif examples that support the SM ciphers and need to have this file available not only here, but also in the ESP Registry. See also #6708
wolfssl_client
TLS example.Fixes zd# n/a
Testing
Tested with ESP32 embedded apps only.
Checklist