Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Espressif wolfcrypt updates #7035

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

gojimmypi
Copy link
Contributor

@gojimmypi gojimmypi commented Dec 6, 2023

Description

Adds and/or cleans up wolfcrypt support for ESP-IDF v5.1 for the following SoC chips:

  • esp32
  • esp32s2
  • esp32c3
  • esp32s3
  • esp32c2
  • esp32c6
  • esp32h2

Included is a compile-only fix for esp32c2 and esp32h2. I'll have a new benchmark.c update in the near future.

The companion #7037 updates the respective benchmark code.

See #6234 for a roadmap of Espressif updates.

Fixes zd# n/s

Testing

How did you test?

Espressif only testing

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

#if defined(NO_ESP32WROOM32_CRYPT)
#undef NO_ESP32WROOM32_CRYPT
#define NO_ESP32_CRYPT
#warning "Please use NO_ESP32_CRYPT not NO_ESP32WROOM32_CRYPT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend using #error, not #warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dgarske dgarske removed their assignment Dec 6, 2023
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Over to PR cap.

@dgarske dgarske removed their assignment Dec 6, 2023
@gojimmypi gojimmypi mentioned this pull request Dec 8, 2023
4 tasks
@JacobBarthelmeh JacobBarthelmeh merged commit 448b836 into wolfSSL:master Dec 8, 2023
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants