Generic Memory Pools #7418
Merged
Generic Memory Pools #7418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Modify wolfSSL_CTX_load_static_memory() to use wc_LoadStaticMemory() instead of reimplementing it. 2. Initialize the pointers in wc_LoadStaticMemory() to null. 3. Whitespace changes.
1. Add the function wc_LoadStaticMemory_ex(), which is a generic version of wc_LoadStaticMemory(). 2. Modify wc_LoadStaticMemory() to call wc_LoadStaticMemory_ex() with the bucket lists. 3. Rename the function wolfSSL_load_static_memory() as wc_partition_static_memory(), make it static, move it higher in the file.
1. Add generic function wolfSSL_StaticBufferSz_ex() where one specifies the memory bucket list sizes and distribution. 2. Rewrote wolfSSL_StaticBufferSz() in terms of the new function. 3. Changed the list pointers on wc_LoadStaticMemory_ex() and wc_init_memory_heap() to be pointers to const.
1. Add checks for listSz against WOLFMEM_MAX_BUCKETS. 2. Use WOLFMEM_DEF_BUCKETS for the size when using the default memory descriptions. 3. Whitespace.
1. Make the function wolfSSL_GetMemStats() public.
ejohnstown
force-pushed
the
generic-pool
branch
from
ae7e091
to
0b5c83f
Compare
JacobBarthelmeh
previously approved these changes
Apr 25, 2024
billphipps
previously approved these changes
Apr 26, 2024
ejohnstown
dismissed stale reviews from billphipps and JacobBarthelmeh
via
5922649
1. Added some extra parameter checking to wc_LoadStaticMemory_ex(). 2. Added some extra parameter checking to wc_StaticBufferSz_ex(). 3. Rename some parameters and add some logging prints. 4. Some static functions have some parameter checking and they are only calling in one spot, remove it.
ejohnstown
force-pushed
the
generic-pool
branch
from
5922649
to
d239948
Compare
billphipps
previously approved these changes
Apr 27, 2024
|
Setting up a heap initializes a mutex, maybe. It isn't cleaned up if needed. |
1. Add API test for function `wc_LoadStaticMemory_ex()`.
1. Add API for function `wc_UnloadStaticMemory()` which frees the mutex used by the static memory pool. 2. Update the `wc_LoadStaticMemory_ex()` test to free the static memory pool's mutex on each successful test case.
ejohnstown
force-pushed
the
generic-pool
branch
from
2db9c92
to
6be5526
Compare
JacobBarthelmeh
approved these changes
Apr 30, 2024
SparkiDev
approved these changes
Apr 30, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Generic Memory Pools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wc_LoadStaticMemory_ex(), updated support functions to work with it. Reimplementedwc_LoadStaticMemory()in terms of the new API.wolfSSL_CTX_load_static_memory()to usewc_LoadStaticMemory()rather than reimplementing it.Fixes 17726
Testing
The code should work the same with and without the changes.
Checklist