zephyr no malloc #7438
Merged
zephyr no malloc #7438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julek-wolfssl
commented
Apr 17, 2024
julek-wolfssl
commented
- cert gen
- csr gen
- pkcs12
- Compiles for Zephyr 3.4.0 and 2.7.4
- Add support for CONFIG_POSIX_API
julek-wolfssl
force-pushed
the
zephr-no-malloc
branch
2 times, most recently
from
5e836f9
to
b117d03
Compare
billphipps
previously approved these changes
Apr 26, 2024
| @@ -3668,11 +3668,13 @@ char* mystrnstr(const char* s1, const char* s2, unsigned int n) | |||
|
|
|||
| #elif defined(WOLFSSL_ZEPHYR) | |||
|
|
|||
| void* wolfsslThreadHeapHint = NULL; | |||
There was a problem hiding this comment.
Consider using the mechanic being introduced in #7478. This would allow your code to continue to pass NULL's in here.
There was a problem hiding this comment.
I'll wait for that PR to merge and use it instead. Good idea.
| #undef HAVE_FFDHE_2048 | ||
| #define HAVE_FFDHE_2048 | ||
|
|
||
| #define WOLFSSL_NO_MALLOC |
There was a problem hiding this comment.
Maybe add #undef WOLFSSL_NO_MALLOC?
Consider adding small stack as well to increase the pressure on the static memory?
There was a problem hiding this comment.
Adding the undef. I'll leave it as is for now as this is configuration being used by users.
julek-wolfssl
force-pushed
the
zephr-no-malloc
branch
from
13d7460
to
a4d8274
Compare
- cert gen - csr gen - pkcs12 - Compiles for Zephyr 3.4.0 and 2.7.4 - Add support for CONFIG_POSIX_API
Co-authored-by: Bill Phipps <[email protected]>
julek-wolfssl
force-pushed
the
zephr-no-malloc
branch
from
a4d8274
to
e35402b
Compare
julek-wolfssl
force-pushed
the
zephr-no-malloc
branch
from
e35402b
to
14ce8ce
Compare
julek-wolfssl
assigned billphipps and wolfSSL-Bot and unassigned julek-wolfssl and billphipps
douzzer
approved these changes
May 9, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
zephyr no malloc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.