Srtp kdf optest #7470
Merged
Srtp kdf optest #7470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: Do not merge this PR before merging #7462 (not sure what is taking so long on the other one?) This PR contains some of the same commits as work is progressing faster than merges are happening. |
kaleb-himes
force-pushed
the
SRTP-KDF-OPTEST
branch
from
526adee
to
39d3144
Compare
|
rebased on master. |
kaleb-himes
force-pushed
the
SRTP-KDF-OPTEST
branch
2 times, most recently
from
ac462a2
to
1ea3a9b
Compare
|
retest this please |
kaleb-himes
force-pushed
the
SRTP-KDF-OPTEST
branch
from
28d8cf6
to
76527c3
Compare
dgarske
requested changes
May 15, 2024
| * non-testable requirement. wolfCrypt will log it when appropriate but | ||
| * take no action */ | ||
| if (iterations < 1000) { | ||
| WOLFSSL_MSG("WARNING: Iteration < 1,000, see SP800-132 section 5.2"); |
There was a problem hiding this comment.
Is this "warning" sufficient? Won't be noticed unless DEBUG_WOLFSSL is set. Should it return a new error code?
There was a problem hiding this comment.
Yes this is sufficient per the comment this is not enforceable.
| @@ -43,6 +43,10 @@ | |||
| WOLFSSL_LOCAL int wolfCrypt_FIPS_HMAC_sanity(void); | |||
| #endif | |||
|
|
|||
| #if FIPS_VERSION3_GE(6,0,0) | |||
| #define FIPS_ALLOW_SHORT 1 | |||
There was a problem hiding this comment.
Should this new FIPS macro include HMAC in the name? Would be nice if wc_HmacSetKey_ex was unsigned and actually a flag / bit mask. Currently its 0 or non-zero only.
dgarske
approved these changes
May 15, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Srtp kdf optest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposing a service API for the new submission effort (module v6.0.0) makes these checks now being exposed passable while running in FIPS mode.
Testing
Using the operational test app
Checklist