Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMS, XMSS: move code into wolfCrypt #7500

Merged
merged 1 commit into from
May 7, 2024

Conversation

SparkiDev
Copy link
Contributor

Description

Move implementations of LMS and XMSS into wolfCrypt and use by default.

Testing

Regression tested LMS and XMSS.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this May 3, 2024
@SparkiDev SparkiDev requested a review from philljj May 3, 2024 01:24
wolfssl/wolfcrypt/wc_lms.h Outdated Show resolved Hide resolved
wolfcrypt/src/wc_lms.c Outdated Show resolved Hide resolved
wolfcrypt/src/wc_lms_impl.c Show resolved Hide resolved
@SparkiDev
Copy link
Contributor Author

I've forced a sync of pqcrypto and copied the files over again.

configure.ac Show resolved Hide resolved
configure.ac Show resolved Hide resolved
Move implementations of LMS and XMSS into wolfCrypt and use by default.
@SparkiDev
Copy link
Contributor Author

retest this please

@philljj
Copy link
Contributor

philljj commented May 3, 2024

Retest this please.

@SparkiDev SparkiDev assigned philljj and wolfSSL-Bot and unassigned SparkiDev May 6, 2024
@philljj philljj self-requested a review May 7, 2024 04:07
@philljj philljj removed their assignment May 7, 2024
Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests all good.

[in-tree-lms-xmss-wolfssl-all-gcc-latest] [1 of 6] [e47f1d4190]
    autogen.sh e47f1d4190...   real 0m16.881s  user 0m14.670s  sys 0m1.340s
    configure...   real 0m17.843s  user 0m6.623s  sys 0m13.144s
    build...   real 0m41.095s  user 2m30.147s  sys 0m9.838s
    check...   real 0m25.821s  user 0m18.369s  sys 0m11.221s
    in-tree-lms-xmss-wolfssl-all-gcc-latest OK
[in-tree-lms-xmss-wolfssl-all-clang-tidy] [2 of 6] [e47f1d4190]
    configure...   real 0m25.728s  user 0m11.404s  sys 0m16.173s
    build...   real 2m36.321s  user 18m32.619s  sys 0m47.231s
    check...   real 0m25.632s  user 0m21.347s  sys 0m11.311s
    in-tree-lms-xmss-wolfssl-all-clang-tidy OK
[in-tree-lms-xmss-wolfssl-all-sanitizer] [3 of 6] [e47f1d4190]
    configure...   real 0m20.011s  user 0m8.432s  sys 0m13.471s
    build...   real 2m23.179s  user 10m20.806s  sys 0m16.832s
    check...   real 0m31.339s  user 0m30.204s  sys 0m21.225s
    in-tree-lms-xmss-wolfssl-all-sanitizer OK
[in-tree-lms-xmss-wolfssl-all-clang-sanitizer] [4 of 6] [e47f1d4190]
    configure...   real 0m27.503s  user 0m12.613s  sys 0m16.744s
    build...   real 1m39.613s  user 7m34.289s  sys 0m14.539s
    check...   real 0m27.992s  user 0m25.700s  sys 0m18.363s
    in-tree-lms-xmss-wolfssl-all-clang-sanitizer OK
[in-tree-lms-xmss-wolfssl-all-cppcheck] [5 of 6] [e47f1d4190]
    configure...   real 0m17.603s  user 0m6.543s  sys 0m12.928s
    cppcheck...   real 1m15.841s  user 12m46.903s  sys 1m1.772s
    in-tree-lms-xmss-wolfssl-all-cppcheck OK
[in-tree-lms-xmss-wolfssl-cross-aarch64-all-armasm-unittest-sanitizer] [6 of 6] [e47f1d4190]
    using aarch64-unknown-linux-gnu-gcc 12.3.1
    configure...   real 0m22.457s  user 0m9.569s  sys 0m14.874s
    build...   real 3m24.655s  user 12m54.012s  sys 0m20.891s
    unit.test...   real 2m20.388s  user 2m16.490s  sys 0m0.895s
    in-tree-lms-xmss-wolfssl-cross-aarch64-all-armasm-unittest-sanitizer OK
final tally: all 6 selected checks succeeded for e47f1d4190.

also clean: check-file-modes check-source-text check-configure

@douzzer douzzer merged commit 4e6a345 into wolfSSL:master May 7, 2024
114 checks passed
jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants