Add pkcs12 tests for wolfcrypt #7502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test with WOLFSSL_NO_MALLOC fails: |
…e per review comments
…heap hints and devid and use it in pkcs12 test
dgarske
requested changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing PKCS12 tests in test.c are really for the PKCS12 password based KDF functionality in pwdbased.c, so those have been renamed pcks12_kdf tests and a new function with the same symbol name now tests the APIs in pkcs12.h. Function wc_PKCS12_parse() yields an allocated WC_DerCertList structure, so I added a new publicly exposed associated free function, the existing wc_FreeCertList() is local and does not follow naming conventions, so I added a public wrapper for it. Stack sizes for certs are no larger than the ones used in the existing kyber tests.