Fix conversion #7520
Fix conversion #7520
Conversation
bandi13
force-pushed
the
fixConversion
branch
7 times, most recently
from
d72da4f
to
647ab96
Compare
|
@bandi13 , seems like: |
|
Oh for sure there are a ton more to do. I was basically going through by type of error, not based on file the error occurs in. At some point I ended up scripting some of the changes. Ultimately, I'd like to have |
| byte *data; | ||
|
|
||
| (void)heap; | ||
| /* okmLen (2) + protocol|label len (1) + info len(1) + protocollen + | ||
| * labellen + infolen */ | ||
| len = 4 + protocolLen + labelLen + infoLen; | ||
| len = (size_t)4 + protocolLen + labelLen + infoLen; |
There was a problem hiding this comment.
Prefer to solve with 4U not cast to make unsigned.
| @@ -1690,7 +1690,7 @@ const char* wolfSSL_get_shared_ciphers(WOLFSSL* ssl, char* buf, int len) | |||
| return NULL; | |||
|
|
|||
| cipher = wolfSSL_get_cipher_name_iana(ssl); | |||
| len = min(len, (int)(XSTRLEN(cipher) + 1)); | |||
| len = (int)min((word32)len, (int)(XSTRLEN(cipher) + 1)); | |||
There was a problem hiding this comment.
Our MIN() uses word32, however I'm not sure that is true for all cases. But for our testing purposes this should be fine.
Fix conversion
Fix issues related to
-Wconversionand-Wsign-conversion. Most notably where a variable needs to be cast to a different type. Not including implicit type upgrades that happen in equations (ie: uint8 + uint16).