-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IDE/PlatformIO; add wolfSSL Benchmark and Test Examples #7528
Conversation
5d4241c
to
fe5e595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both Benchmark as well as Test examples. Benchmark works, Test needs to be fixed.
@bandi13 thanks for testing this for a test drive! It's actually a good thing that the example test app is failing here. The published wolfSSL 5.7.0-rev.3b (Post Release Update for PlatformIO) referenced by the example on PlatformIO is stale. I introduced a SHA interleave test in #7262. This test is included in the stale, post 5.7.0 version published at PlatformIO and is failing as desired, properly detecting the interleave problem. The failing SHA interleave was the root cause of the SRP errors noted in #7210. The SHA/SRP problem was fixed in #7505, merged within the last day but not yet published to PlatformIO. Unfortunately (or fortunately, depending on your perspective), I found a new problem with the latest version of wolfSSL for PlatformIO as noted in #7533. My plan is to create a new PR to fix #7533 and then publish a new, post-release wolfSSL to PlatformIO. I don't think there's any problem with this particular PR 7528, as the root cause is the currently published wolfSSL version at PlatformIO. I've confirmed the latest Reminder the SRP for the Apple HomeKit also requires the
See the 4 different versions of wolfSSL available at PlatformIO:
Note the Arduino version of the PlatformIO library should not be confused with the Official wolfSSL for Arduino: https://github.com/wolfSSL/Arduino-wolfSSL which is published to https://www.arduino.cc/reference/en/libraries/wolfssl/ This initial rollout has been a little more bumpy than anticipated. I do believe that once the appropriate platform-specific fixes are implemented, that the regular release cycle should be considerably more stable and graceful. |
@gojimmypi do you want to rebase the PR or accept as-is? |
@dgarske please stand by. I'd like to rebase and apply some minor updates. Testing is taking longer than anticipated. |
Hi @dgarske I've refreshed from upstream and made some minor changes in 503bbbe. Key to getting this to work was having the proper fresh update of wolfSSL published to PlatformIO. Tested and confirmed working are these versions in @bandi13 if you could please, take this for a test drive again & let me know how it goes. |
Jenkins retest this please. |
@@ -0,0 +1,791 @@ | |||
/* examples/configs/user_settings_platformio.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new file user_settings_platformio.h
missing from include.am?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Updated this, the respective README, and changed sort order.
@@ -0,0 +1,24 @@ | |||
#include <wolfssl/wolfcrypt/settings.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible please add our standard GPL header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass. Benchmarks also run on an ESP32.
Nice work!
Introduce IDE/PlatformIO; add wolfSSL Benchmark and Test Examples
Description
Adds
IDE/PlatformIO
examples.See also #7413 and platformio/platformio-registry#85
Fixes zd# n/a
Testing
How did you test?
Tested manually using PlatformIO in VS Code.
Checklist