ECC: handle zero in wc_ecc_mulmod() #7532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
wc_ecc_mulmod_zero
branch
from
4a2aeda
to
4fd31f7
Compare
Public API needs to handle multiplying by zero as the underlying code doesn't and needn't.
SparkiDev
force-pushed
the
wc_ecc_mulmod_zero
branch
from
4fd31f7
to
3675468
Compare
|
Retest this please |
dgarske
approved these changes
May 15, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
ECC: handle zero in wc_ecc_mulmod()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Public API needs to handle multiplying by zero as the underlying code doesn't and needn't.
Fixes #7530
Testing
Added test case.
Failed before change made to wc_ecc_mulmod().
Checklist