-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocsp stapling improvements #7702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizlik
force-pushed
the
ocspv2
branch
3 times, most recently
from
July 2, 2024 07:43
c99c716
to
a9de1a6
Compare
Retest this please |
JacobBarthelmeh
requested changes
Jul 3, 2024
JacobBarthelmeh
previously approved these changes
Jul 5, 2024
julek-wolfssl
previously approved these changes
Jul 5, 2024
src/ocsp.c
Outdated
Comment on lines
602
to
604
if (ca == NULL && pendingCAs != NULL) { | ||
ca = findSignerByName(pendingCAs, single->issuerHash); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab++
rizlik
dismissed stale reviews from julek-wolfssl and JacobBarthelmeh
via
July 5, 2024 15:29
0531706
JacobBarthelmeh
approved these changes
Jul 5, 2024
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements of OCSP stapling response handling