Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the unknown extension callback. #7730

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

anhu
Copy link
Member

@anhu anhu commented Jul 9, 2024

This will allow the user to pass in a context pointer. Allows them to avoid global variables.
Fixes ZD 18252

@anhu anhu requested a review from wolfSSL-Bot July 9, 2024 17:51
@anhu anhu self-assigned this Jul 9, 2024
This will allow the user to pass in a context pointer. Allows them to avoid
global variables.

We also add unknown extensions callback when processing a CA in cert manager
as CA certs can have unknown extensions as well.

Fixes ZD 18252
@anhu
Copy link
Member Author

anhu commented Jul 12, 2024

retest this please

@anhu anhu assigned wolfSSL-Bot and unassigned anhu Jul 22, 2024
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. @SparkiDev please review.

wolfcrypt/src/asn.c Show resolved Hide resolved
@anhu anhu requested a review from SparkiDev July 23, 2024 18:35
@SparkiDev SparkiDev removed the request for review from wolfSSL-Bot July 23, 2024 22:37
@SparkiDev SparkiDev merged commit a34ea32 into wolfSSL:master Jul 23, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants