Memory usage improvements #7901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
memusage_8
branch
5 times, most recently
from
cbaacf0
to
09412a9
Compare
douzzer
requested changes
Aug 27, 2024
There was a problem hiding this comment.
looks OK on cursory read-through, but it provokes a slew of -Wconversions (see attached)
SparkiDev-memusage_8-09412a9321-allcryptonly-Wconversion-intelasm-build.html.gz
SparkiDev
force-pushed
the
memusage_8
branch
3 times, most recently
from
c3d1b88
to
795d651
Compare
SparkiDev
force-pushed
the
memusage_8
branch
from
795d651
to
959a040
Compare
kdf.c: wc_PRF() - No need for previous, reuse current. sha256.c: Transform_Sha256() - Add slow but small version for many register implementation. sp_int.h: Change 'used' and 'size' fields to 16-bit types when possible. sp_int.c: Fixes for 16-bit used.
SparkiDev
force-pushed
the
memusage_8
branch
from
959a040
to
88c3e0a
Compare
dgarske
approved these changes
Sep 4, 2024
douzzer
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kdf.c: wc_PRF() - No need for previous, reuse current.
sha256.c: Transform_Sha256() - Add slow but small version for many register implementation.
sp_int.h: Change 'used' and 'size' fields to 16-bit types when possible.
sp_int.c: Fixes for 16-bit used.
Testing
Memusage testing
Checklist