20240905-whitespace-and-utf8-cleanup #7949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewlines, remove stray UTF8 nonprintables (BOMs) and ASCIIfy stray homoglyphs (spaces and apostrophes), guided by expanded coverage in wolfssl-multi-test check-source-text.
dgarske
reviewed
Sep 5, 2024
| @@ -181,7 +181,7 @@ jobs: | |||
| - name: Checkout hostap | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| repository: julek-wolfssl/hostap-mirror | |||
| repository: julek-wolfssl/hostap-mirror | |||
There was a problem hiding this comment.
@julek-wolfssl is it possible to move this mirror to a wolfssl org managed repo?
There was a problem hiding this comment.
Yes it is. Actually since we are only using certain commits, we should move it to a cache that is created from the true remote.
dgarske
reviewed
Sep 5, 2024
| @@ -411,7 +411,7 @@ void AES_invert_key(unsigned char* ks_p, word32 rounds_p) | |||
| static const uint32_t L_AES_ARM32_rcon[] = { | |||
| 0x01000000, 0x02000000, 0x04000000, 0x08000000, | |||
| 0x10000000, 0x20000000, 0x40000000, 0x80000000, | |||
| 0x1b000000, 0x36000000, | |||
| 0x1b000000, 0x36000000, | |||
There was a problem hiding this comment.
This might be generated code. @SparkiDev ?
dgarske
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up trailing whitespace and misplaced CRLFs, add missing final newlines, remove stray UTF8 nonprintables (BOMs) and ASCIIfy stray homoglyphs (spaces and apostrophes), guided by expanded coverage in
wolfssl-multi-test check-source-text.git diff -wwill be helpful for review.