Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for OPENSSL_VERSION_* definitions before defining #7950

Closed

Conversation

rdmark
Copy link

@rdmark rdmark commented Sep 6, 2024

Description

When using WolfSSL side by side with OpenSSL, the OPENSSL_VERSION_NUMBER and OPENSSL_VERSION_TEXT macros get redefined, triggering compiler warnings. This patch adds definition checks in WolfSSL for these two.

For context, my specific usecase in the Netatalk project we use WolfSSL for DHCAST128 encryption, but still rely on OpenSSL for certain symbols that aren't available in WolfSSL, e.g. CAST_* in openssl/cast.h

Testing

Tested by building WolfSSL against Netatalk.

Checklist

N/A (I think)

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@dgarske
Copy link
Contributor

dgarske commented Sep 6, 2024

Hi @rdmark ,

I like the addition. I don't see a contributor agreement on file. We can either take this as a feature request or we can get an agreement setup. Are you planning to make additional code contributions? If you'd like to start the agreement process please email support at wolfssl dot com.

Thanks,
David Garske, wolfSSL

@rdmark
Copy link
Author

rdmark commented Sep 7, 2024

@dgarske Hi, thanks for taking a look at my PR. I shot you an email now regarding the contributor agreement. While I don't have another PR in the pipeline right now, it is not impossible I will in the future.

@douzzer
Copy link
Contributor

douzzer commented Sep 12, 2024

superseded by #7971

@douzzer douzzer closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants