Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wolfcrypt settings.h for Espressif ESP-IDF, template update #7953

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

gojimmypi
Copy link
Contributor

Description

Building on the capabilities introduced in #7936, #7893, #7866 this PR moves some of the common Espressif Kconfig settings and feature detection from user_settings.h to the wolfcrypt settings.h file.

Included is a minor update & code sync to the reference template application. See the respective user_settings.h for an example of how Kconfig settings (via sdkconfig.h) are used.

I'm planning on updates to all of the other Espressif examples (test, benchmark, client, server) very soon, hopefully in time for the next release.

The intention is for all wolfSSL examples and reference code to have exactly the same component user_settings.h, Kconfig, and CMakeLists.txt files. All the application-specific settings can then be assigned via the respective sdkconfig.defaults files and/or changed via idf.py menuconfig rather than manual edits to user_settings.h. This is important for the wolfssl Managed Component that doesn't like source code edits, including changes to the user_settings.h.

There's no adverse effect for non-Managed Component apps. The user_settings.h can still be edited. There's still a peripheral benefit of having consistent files throughout all the examples.

Fixes zd# n/a

Testing

How did you test?

Primarily tested in the Espressif environment, with a quick make clean and make test before PR submission.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi
Copy link
Contributor Author

Jenkins retest this please

@douzzer douzzer merged commit 95c94f5 into wolfSSL:master Sep 12, 2024
133 checks passed
@gojimmypi gojimmypi deleted the pr-espressif-settings branch October 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants