Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to remove HAVE_RSA references. Correct NO_MALLOC RSA test bug. #7977

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

billphipps
Copy link
Contributor

Description

  1. Remove references to HAVE_RSA in wolfssl source. Note this removal now reenables a few api.c tests.
  2. Correct a WOLFSSL_NO_MALLOC bug within wolfcrypttest that sometimes failed due to a buffer overflow.

Testing

Testing with NO_MALLOC locally on MacOS with wolfHSM as well as commit-tests.sh. I expect the nightlies may exercise the RSA api.c test so we may have some additional findings on different configurations.

Checklist

  • [ N/A ] added tests. This change reenables some API tests. We are still missing full NO_MALLOC coverage.
  • [ N/A ] updated/added doxygen
  • [ N/A ] updated appropriate READMEs
  • [ N/A ] Updated manual and documentation

@billphipps
Copy link
Contributor Author

retest this please

Copy link
Contributor

@bandi13 bandi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bandi13 bandi13 merged commit 9666394 into wolfSSL:master Sep 16, 2024
135 checks passed
@billphipps billphipps deleted the have_rsa_fix branch September 16, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants