Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dilithium: small cleanup to support wolfboot. #7983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Sep 18, 2024

Description

dilithium cleanup:

  • Missing wc_dilithium_export_private_only define in dilithium.h. Also fixed some define args.
  • Some API not covered in tests.
  • typo in dilithium.c

Discovered when building wolfboot with ML-DSA/dilithium.

@philljj philljj self-assigned this Sep 18, 2024
@philljj
Copy link
Contributor Author

philljj commented Sep 18, 2024

Retest this please

@philljj philljj assigned wolfSSL-Bot and unassigned philljj Sep 18, 2024
@philljj
Copy link
Contributor Author

philljj commented Sep 20, 2024

Still working on this, have some more changes.

@philljj philljj changed the title tiny dilithium cleanup: missing define, typo. dilithium: small cleanup to support wolfboot. Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants