Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wconversion in the tls* and api/test* files #7988

Merged
merged 9 commits into from
Oct 2, 2024

Conversation

gasbytes
Copy link
Contributor

Description

Fix issues related to -Wconversion and -Wsign-conversion in the tls* api/test* files.

@JacobBarthelmeh
Copy link
Contributor

Having the proper casts is nice thanks, it's failing some CI tests though. Putting the assignee back to @gasbytes until resolved.

@dgarske
Copy link
Contributor

dgarske commented Sep 30, 2024

@gasbytes

tests/api.c:73079:12: error: implicit conversion loses integer precision: 'unsigned long' to 'word32' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
    return lh_strhash(s[3]);
    ~~~~~~ ^~~~~~~~~~~~~~~~
./wolfssl/openssl/lhash.h:55:29: note: expanded from macro 'lh_strhash'
#define lh_strhash          wolfSSL_LH_strhash
                            ^
1 error generated.

@gasbytes gasbytes assigned wolfSSL-Bot and unassigned gasbytes Oct 1, 2024
@douzzer douzzer merged commit 24d1b11 into wolfSSL:master Oct 2, 2024
139 checks passed
@gasbytes gasbytes deleted the fix-conversion branch October 3, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants