Small Stack ECC Pairwise Consistency Test #7992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update the ECC PCT to use the key's heap to allocate any buffers for the test. This is similar to how RSA does it. 2. Put the buffers on the stack if not using small stack option.
ejohnstown
force-pushed
the
ecc-pct-ss
branch
2 times, most recently
from
a81efc0
to
74981c9
Compare
JacobBarthelmeh
previously approved these changes
Sep 18, 2024
ejohnstown
force-pushed
the
ecc-pct-ss
branch
from
74981c9
to
a81efc0
Compare
JacobBarthelmeh
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the ECC PCT to use the key's heap when allocating buffers or an RNG for the test. This is how RSA's PCT does it. Also put the test buffers on the stack when not using the small-stack build.
(ZD 17705)
Testing
Built with scan-build and gcc with address sanitize. Also ran it through valgrind.
Checklist