Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TSIP RSA Public Enc/Private Dec #8122

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

miyazakh
Copy link
Contributor

Description

Add TSIP RSA public Encryption/Private Decryption

Testing

Run unit test on RX72N

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@miyazakh miyazakh self-assigned this Oct 29, 2024
@dgarske dgarske self-requested a review October 29, 2024 13:58
@dgarske dgarske self-assigned this Oct 29, 2024
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[check-source-text] [2 of 7] [wolfssl]
trailing whitespace:
./IDE/Renesas/e2studio/RX72N/EnvisionKit/wolfssl_demo/user_settings.h:249:····
./wolfcrypt/src/port/Renesas/renesas_tsip_rsa.c:238:················
./wolfcrypt/src/port/Renesas/renesas_tsip_rsa.c:258:················
weird control chars, hard tabs, CRs, trailing whitespace:
./wolfcrypt/src/port/Renesas/renesas_common.c:262:        »(info->pk.rsa.type == RSA_PRIVATE_DECRYPT ||
./wolfcrypt/src/port/Renesas/renesas_common.c:278:        »» info->pk.rsa.type == RSA_PUBLIC_DECRYPT) {
overlong lines added:
wolfcrypt/src/port/Renesas/renesas_tsip_rsa.c:249                                                             "1024 or 2048 bits.");
wolfcrypt/src/port/Renesas/renesas_tsip_rsa.c:269                                                             "1024 or 2048 bits.");

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace:
./IDE/Renesas/e2studio/RX72N/EnvisionKit/wolfssl_demo/user_settings.h:249:····
    check-source-text fail_A```

@dgarske dgarske removed their assignment Oct 29, 2024
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Awaiting merge until customer provides feedback.

@dgarske dgarske assigned dgarske and unassigned miyazakh Oct 29, 2024
@dgarske dgarske assigned miyazakh and unassigned dgarske Nov 4, 2024
dgarske
dgarske previously approved these changes Nov 5, 2024
@dgarske dgarske self-assigned this Nov 5, 2024
dgarske and others added 2 commits November 6, 2024 10:37
…Fix crypto callback to properly support PKCSv1.5 sign/verify and encrypt/decrypt based on padding info.
@dgarske dgarske assigned wolfSSL-Bot and unassigned dgarske and miyazakh Nov 13, 2024
@dgarske dgarske requested a review from douzzer November 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants