Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual folder names #344

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented May 22, 2024

fixes #343

related #207 is fixed with #345

Note: This is my first ever Android code, tested on the emulator and on real phone (Samsung A8, Android 9.0).

sshfs-win before (can't access the folders):

 Volume in drive X has no label.
 Volume Serial Number is 2C8E-EB18

 Directory of X:\

1970.01.01  02:00    <DIR>          \fs
1970.01.01  02:00    <DIR>          \rosaf
1970.01.01  02:00    <DIR>          \saf
1970.01.01  02:00    <DIR>          \superuser
               0 File(s)              0 bytes
               4 Dir(s)  1 073 741 824 000 bytes free

After

 Volume in drive X has no label.
 Volume Serial Number is 6940-EBE8

 Directory of X:\

1970.01.01  02:00    <DIR>          fs
1970.01.01  02:00    <DIR>          rosaf
1970.01.01  02:00    <DIR>          saf
1970.01.01  02:00    <DIR>          superuser
               0 File(s)              0 bytes
               4 Dir(s)  1 073 741 824 000 bytes free

SFTP Drive before (can access the folders with these strange names):

 Volume in drive X is lmagyar
 Volume Serial Number is 1234-5678

 Directory of X:\

1970.01.01  02:00    <DIR>          $fs$fs
1970.01.01  02:00    <DIR>          $fs$superuser
1970.01.01  02:00    <DIR>          $fs$saf
1970.01.01  02:00    <DIR>          $fs$rosaf
               0 File(s)              0 bytes
               4 Dir(s)  9 223 372 036 854 775 296 bytes free

After

 Volume in drive X is android-emulator
 Volume Serial Number is 1234-5678

 Directory of X:\

1970.01.01  02:00    <DIR>          fs
1970.01.01  02:00    <DIR>          superuser
1970.01.01  02:00    <DIR>          saf
1970.01.01  02:00    <DIR>          rosaf
               0 File(s)              0 bytes
               4 Dir(s)  9 223 372 036 854 775 296 bytes free

@lmagyar lmagyar mentioned this pull request May 22, 2024
@wolpi
Copy link
Owner

wolpi commented Jun 2, 2024

looks good, thanks

@wolpi wolpi merged commit e718e1b into wolpi:master Jun 2, 2024
1 check passed
@wolpi wolpi added this to the 7.2 milestone Jun 2, 2024
@lmagyar lmagyar deleted the pr-fix-virtual-folder-names branch June 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual Folders' "/" folder listing doesn't show anything
2 participants