Make SAF, ROSAF and virtual directories searchable #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yes, that makes sense.
That way it would work for FTP, too. |
|
Yeah, nice catch. :) I was so concentrated on the sftp... I will do it after dinner. :D |
|
So, no change, because isExecutable() is only part of SshFile interface and not part of FtpFile interface (it seems that ftp doesn't use this info), and that's why I've put it into XxxSshFile. |
|
I still think this can be done in AbsractFile, moved it there. Thanks! |
lmagyar
pushed a commit
to lmagyar/prim-ftpd
that referenced
this pull request
Jun 8, 2024
wolpi
added a commit
that referenced
this pull request
Jun 9, 2024
|
last commit should have been assigned to #352 |
lmagyar
pushed a commit
to lmagyar/prim-ftpd
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain old FS gets this info from the real FS, and folders are executable=searchable (rwxrwxrwx).
In case of SAF and ROSAF: set isExecutable() true for folders.
In case of virtual: use the backing FS or be default true (for the / and the /fs, etc. folders).
Without executable bit set, the folders created by SSHFS on the client can't be selected as working directories. (eg.
cd .../saf/Anythingresults in "Access denied")Note: The ROSAF part is not tested.