Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAF: disable move when renaming #377

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Sep 3, 2024

fixes #368

DocumentFile.renameTo() can change only the display-name, this PR returns false if the destination and source paths are different.

Note: With read-write-ROSAF it would be possible, DocumentsContract has a moveDocument() method.

@wolpi wolpi merged commit a0bfa0c into wolpi:master Oct 5, 2024
1 check passed
@wolpi
Copy link
Owner

wolpi commented Oct 5, 2024

Merged it even thogh it is not clear how long this code will last

@wolpi wolpi added this to the 7.3 milestone Oct 5, 2024
wolpi added a commit that referenced this pull request Oct 5, 2024
@lmagyar lmagyar deleted the pr-fix-move-on-saf branch October 5, 2024 18:22
lmagyar pushed a commit to lmagyar/prim-ftpd that referenced this pull request Oct 5, 2024
# Conflicts:
#	primitiveFTPd/src/org/primftpd/filesystem/SafFile.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Move Files with SAF
2 participants