Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error handling and prompts in the onboarding #1993

Closed
7 tasks done
eason9487 opened this issue Jun 20, 2023 · 1 comment
Closed
7 tasks done

Improve the error handling and prompts in the onboarding #1993

eason9487 opened this issue Jun 20, 2023 · 1 comment
Assignees

Comments

@eason9487
Copy link
Member

eason9487 commented Jun 20, 2023

Goals

During the onboarding

  • Prompts for explicit errors such as incorrect input formatting or missing required fields to reduce confusion for users
  • Make error messages more specific as to which part of the error occurred

The main scope is the Onboarding flow and the Edit Free Listings page. (The editing page basically reuses most of the code)

Related tasks

📌 Deal with technical error handling

Tasks

  1. category: refactor type: technical debt
    eason9487
  2. priority: high type: bug
    eason9487
  3. category: i18n google ads impact: high type: enhancement
    eason9487

These tasks are more about technical adjustments. It expects to use the current UI and will not change significantly.

📌 Display form validation errors

Tasks

  1. impact: high type: enhancement
    eason9487

This is the top priority in this project as there were a lot of user reports related to it.

To display the form/data validation errors, the main points of the change are:

  1. Change the timing of triggering form validation and showing errors.
    • Don't disable the "Continue" or "Compete" buttons even if the form validation doesn't pass.
    • The form validation errors are not displayed until the user clicks the above button.
    • After displaying the validation errors, the errors will continue to be updated with user input.
  2. Similar to the Asset Group management page. The error messages are grouped by Card UI and are displayed below the UI layout they belong to.
    • For example:
      image
  3. The # issues pill UI won't be added because the forms other than Asset Group don't have the collapse and expanding interaction.
  4. These changes won't be applied to the modals of shipping setup as the modal should be clear enough and no user seems to have reported a problem with this.
    • Shipping modal:
      image
  5. To be consistent, the event tracking of the above buttons will still be triggered only when the step can be proceeded to the next one or be completed.

📌 Clarify API error messages

Tasks

  1. priority: high site verfication & claim type: enhancement
    eason9487
  2. type: bug
    eason9487
  3. priority: low type: bug
    eason9487

The error messages in these tasks were already handled or shown but may confuse users. It expects to use the current UI or remove the unnecessary error message.

📌 Add tests

  • Add tests for the VerifyPhoneNumberContent component (#2027, #2031)

Links

Project:

  • Project thread: pcTzPl-1yj-p2
@eason9487 eason9487 self-assigned this Jun 20, 2023
@eason9487 eason9487 changed the title (Draft) Improve the error handling and prompts in the onboarding Improve the error handling and prompts in the onboarding Jul 10, 2023
@eason9487
Copy link
Member Author

Close this issue: All listed tasks have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant