Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JavaScript tests for the EditPhoneNumberContent and VerifyPhoneNumberContent components #2031

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Add JavaScript tests for the EditPhoneNumberContent and VerifyPhoneNumberContent components #2031

merged 3 commits into from
Aug 1, 2023

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

This is the final part of 📌 Add tests in #1993.

Add JavaScript tests for theEditPhoneNumberContent and VerifyPhoneNumberContent components.

Detailed test instructions:

  1. Check if the newly added tests fit with the test purpose.
  2. Check if all JS tests can pass.

Changelog entry

@eason9487 eason9487 requested a review from a team July 31, 2023 11:02
@eason9487 eason9487 self-assigned this Jul 31, 2023
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Jul 31, 2023
@eason9487 eason9487 changed the title Add JavaScript tests for theEditPhoneNumberContent and VerifyPhoneNumberContent components Add JavaScript tests for the EditPhoneNumberContent and VerifyPhoneNumberContent components Jul 31, 2023
puntope
puntope approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM @eason9487 thanks for adding tests

@eason9487 eason9487 force-pushed the dev/1993-js-test-phone-number-contents branch from a4f41dd to db45019 Compare August 1, 2023 02:10
@eason9487 eason9487 merged commit 880f744 into develop Aug 1, 2023
4 checks passed
@eason9487 eason9487 deleted the dev/1993-js-test-phone-number-contents branch August 1, 2023 02:15
@eason9487 eason9487 mentioned this pull request Aug 1, 2023
Closed
1 task
@martynmjones martynmjones mentioned this pull request Aug 1, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puntope puntope puntope approved these changes

Assignees

@eason9487 eason9487

Labels
changelog: dev Developer-facing only change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eason9487 @puntope