Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalize Flex, Card and their associated group components imported from @wordpress/components #2036

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Externalize Flex, Card and their associated group components imported from @wordpress/components #2036

merged 2 commits into from
Aug 9, 2023

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Aug 2, 2023 •
edited
Loading

Changes proposed in this Pull Request:

It's part of #1833

Externalize Flex, Card and their associated group components imported from @wordpress/components:

  • Flex
  • FlexBlock
  • FlexItem
  • Card
  • CardBody
  • CardDivider
  • CardFooter
  • CardHeader

💡 These components were used on almost all GLA pages. Therefore, externalizing together would be facilitating the testing.

Detailed test instructions:

  1. npm start or npm run dev
  2. View all GLA pages to see if there are any cards or layouts that don't display correctly.
  3. Search the codebase to check if all these components are imported from 'extracted/@wordpress/components'.

Changelog entry

@eason9487 eason9487 requested a review from a team August 2, 2023 07:43
@eason9487 eason9487 self-assigned this Aug 2, 2023
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Aug 2, 2023
ianlin
ianlin approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, I merged develop into this brach in my local and tested with WP 6.3, visited every page within GL&A and all good.

@eason9487 eason9487 changed the base branch from develop to dev/externalize-wp-packages August 9, 2023 09:28
@eason9487 eason9487 merged commit ec72227 into dev/externalize-wp-packages Aug 9, 2023
6 checks passed
@eason9487 eason9487 deleted the dev/1833-externalize-flex-and-card branch August 9, 2023 09:43
@eason9487 eason9487 mentioned this pull request Aug 4, 2023
Closed
31 tasks
@eason9487 eason9487 mentioned this pull request Aug 22, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianlin ianlin ianlin approved these changes

Assignees

@eason9487 eason9487

Labels
changelog: dev Developer-facing only change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eason9487 @ianlin