Add support for Google Analytics for WooCommerce version 2.0.0 #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog: update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2287 +/- ##
===========================================
+ Coverage 62.2% 63.9% +1.6%
- Complexity 4190 4196 +6
===========================================
Files 748 455 -293
Lines 21547 17853 -3694
Branches 532 0 -532
===========================================
- Hits 13406 11400 -2006
+ Misses 7690 6453 -1237
+ Partials 451 0 -451
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tomalec
reviewed
Feb 29, 2024
| ); | ||
| } | ||
| ); | ||
| if ( version_compare( \WC_GOOGLE_ANALYTICS_INTEGRATION_VERSION, '2.0.0', '>=' ) ) { |
There was a problem hiding this comment.
🚧
I don't get into this line when I run it with the new GA, as the one above returns false.
GLA still expect the old GA settings to be there https://github.com/woocommerce/google-listings-and-ads/blob/3a423a2d5cfca64486c74cf41905d01db1cc4c52/src/Proxies/GoogleGtagJs.php#L24:L33
The latest GA does not set ga_gtag_enabled
There was a problem hiding this comment.
tomalec
added a commit
that referenced
this pull request
Mar 1, 2024
…analytics-version-2-enabled Consider `ga_gtag_enabled=yes` for WCGAI >= 2
tomalec
reviewed
Mar 1, 2024
Co-authored-by: Tomek Wytrębowicz <[email protected]>
tomalec
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Google Analytics for WooCommerce updates how the Global Site Tag is loaded so this PR updates the integration in GLA to support version
2.0.0and above while maintaining backwards compatibility.The main difference is that instead of simply adding a script to the page with a call to
gtag, we now usewp_add_inline_scriptand the Google Analytics for WooCommerce script handle where applicable.Detailed test instructions:
page_viewview_itempurchaseconversionChangelog entry