Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Budget Setup Card. #2552

Open
wants to merge 30 commits into
base: update/2535-consolidate-ad-creation-ccf-merged
Choose a base branch
from

Fix: Step change shows no notice.

096c086
Select commit
Loading
Failed to load commit list.
Open

Update Budget Setup Card. #2552

Fix: Step change shows no notice.
096c086
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2024 in 0s

63.9% (-0.8%) compared to a9a9394

View this Pull Request on Codecov

63.9% (-0.8%) compared to a9a9394

Details

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.9%. Comparing base (a9a9394) to head (096c086).
Report is 2 commits behind head on feature/2459-campaign-creation-flow.

Files with missing lines Patch % Lines
...-ads/budget-section/budget-recommendation/index.js 0.0% 2 Missing and 1 partial ⚠️
js/src/components/paid-ads/budget-section/index.js 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                            @@
##             feature/2459-campaign-creation-flow   #2552      +/-   ##
========================================================================
- Coverage                                   64.8%   63.9%    -0.8%     
========================================================================
  Files                                        801     324     -477     
  Lines                                      22987    5076   -17911     
  Branches                                    1232    1231       -1     
========================================================================
- Hits                                       14887    3245   -11642     
+ Misses                                      7932    1664    -6268     
+ Partials                                     168     167       -1     
Files with missing lines Coverage Δ
js/src/components/paid-ads/budget-section/index.js 11.8% <0.0%> (ø)
...-ads/budget-section/budget-recommendation/index.js 4.0% <0.0%> (ø)

... and 477 files with indirect coverage changes