Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Budget Setup Card. #2552
base: update/2535-consolidate-ad-creation-ccf-merged
Are you sure you want to change the base?
Update Budget Setup Card. #2552
Changes from 4 commits
a57bf14
273d02b
9c30663
103ae13
096c086
76328ea
8d9358d
ea68ee8
dcc6f73
ac68177
052783e
c2fbf1a
61d73eb
f15bfb9
85f5b35
566476d
dc7a4ac
9ddfef4
4af37a3
1b92ecb
ab2db99
983438b
eb18178
35716f0
0cafdb2
79ccefa
fbde5f4
3ea1c12
f6f7ac3
7aaa968
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 60 in js/src/components/paid-ads/budget-section/budget-recommendation/index.js
Codecov / codecov/patch
js/src/components/paid-ads/budget-section/budget-recommendation/index.js#L60
Check warning on line 62 in js/src/components/paid-ads/budget-section/budget-recommendation/index.js
Codecov / codecov/patch
js/src/components/paid-ads/budget-section/budget-recommendation/index.js#L62
Check warning on line 33 in js/src/components/paid-ads/budget-section/index.js
Codecov / codecov/patch
js/src/components/paid-ads/budget-section/index.js#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we no longer need to wait for this response after the country setting is changed? It looks like when the country values change, the text that reads "Tip: Most merchants targeting similar countries set a daily budget of %d USD" does change, so we should probably ensure that is still being tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joemcgill This is no longer require because we are fulfilling the budget recommendation here, so we no longer have to wait to capture the budget recommendation response.
Those assertions will still be tested with the new fulfilment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitrox I'm still unsure why we need to remove this. Could you clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joemcgill Sorry for missing this one.
Initially when we were removing country from (or updating anything in
Select country/s
textbox), a request to budget recommendation endpoint was triggered which we were awaiting to get fulfilled insetupBudgetPage.registerBudgetRecommendationResponse()
Now, as per our new implementation, that request will no longer trigger because we are using the countries that have been selected in step 2 which acts as a superset for step 4 data.
Please let me know if this helps or in case of any other query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitrox Can you check @joemcgill 's comment please? Not sure about this one.