Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Ad Creation #2575

Closed
wants to merge 18 commits into from

Remove country code from edit screen.

8e95434
Select commit
Loading
Failed to load commit list.
Closed

Consolidate Ad Creation #2575

Remove country code from edit screen.
8e95434
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 0s

62.4% (-2.7%) compared to 315fce2

View this Pull Request on Codecov

62.4% (-2.7%) compared to 315fce2

Details

Codecov Report

Attention: Patch coverage is 2.81690% with 69 lines in your changes missing coverage. Please review.

Project coverage is 62.4%. Comparing base (315fce2) to head (8e95434).

Files with missing lines Patch % Lines
js/src/components/paid-ads/ads-campaign/index.js 0.0% 39 Missing and 5 partials ⚠️
...rc/components/paid-ads/ads-campaign/skip-button.js 0.0% 9 Missing and 2 partials ⚠️
...s/paid-ads/ads-campaign/paid-ads-setup-sections.js 0.0% 6 Missing and 2 partials ⚠️
...paid-ads/ads-campaign/paid-ads-features-section.js 0.0% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##             feature/2460-simplify-paid-ads-setup   #2575      +/-   ##
=========================================================================
- Coverage                                    65.0%   62.4%    -2.7%     
=========================================================================
  Files                                         475     334     -141     
  Lines                                       17900    5226   -12674     
  Branches                                        0    1269    +1269     
=========================================================================
- Hits                                        11640    3259    -8381     
+ Misses                                       6260    1781    -4479     
- Partials                                        0     186     +186
Files with missing lines Coverage Δ
.../components/paid-ads/ads-campaign/clientSession.js 25.0% <ø> (ø)
.../src/components/paid-ads/ads-campaign/constants.js 100.0% <100.0%> (ø)
js/src/pages/create-paid-ads-campaign/index.js 10.8% <ø> (ø)
js/src/pages/edit-paid-ads-campaign/index.js 9.4% <ø> (ø)
js/src/setup-ads/ads-stepper/index.js 100.0% <ø> (ø)
.../src/setup-mc/setup-stepper/saved-setup-stepper.js 87.8% <ø> (ø)
...paid-ads/ads-campaign/paid-ads-features-section.js 0.0% <0.0%> (ø)
...s/paid-ads/ads-campaign/paid-ads-setup-sections.js 2.1% <0.0%> (ø)
...rc/components/paid-ads/ads-campaign/skip-button.js 0.0% <0.0%> (ø)
js/src/components/paid-ads/ads-campaign/index.js 0.0% <0.0%> (ø)

... and 799 files with indirect coverage changes

View more details on Codecov