Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the billing setup page from the Ads setup flow #2577

Merged
merged 45 commits into from
Oct 10, 2024
Merged

Remove the billing setup page from the Ads setup flow #2577

merged 45 commits into from
Oct 10, 2024

Commits on Sep 4, 2024

  1. remove ads campaign steps

    @kt-12
    kt-12 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    40ea4eb View commit details
    Browse the repository at this point in the history

  2. cs fixes

    @kt-12
    kt-12 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8a9a10a View commit details
    Browse the repository at this point in the history

  3. e2e support

    @kt-12
    kt-12 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    94c8208 View commit details
    Browse the repository at this point in the history

  4. cs fixes

    @kt-12
    kt-12 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    39a2090 View commit details
    Browse the repository at this point in the history

  5. cs fixes

    @kt-12
    kt-12 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    09871a5 View commit details
    Browse the repository at this point in the history

  6. fix cs issue

    @kt-12
    kt-12 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5b14c07 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. address review comments and also add submitbuttontext

    @kt-12
    kt-12 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    9728b03 View commit details
    Browse the repository at this point in the history

  2. fix doc block

    @kt-12
    kt-12 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    f06b5d2 View commit details
    Browse the repository at this point in the history

  3. cs fixes

    @kt-12
    kt-12 committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    3409919 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. cs fixes

    @kt-12
    kt-12 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0c74f98 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. sert default submitButtonText

    @kt-12
    kt-12 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    779eac3 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. update doc block and remove unused files

    @kt-12
    kt-12 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ef31827 View commit details
    Browse the repository at this point in the history

  2. Update tests/e2e/specs/add-paid-campaigns/add-paid-campaigns.test.js 

    change text

Co-authored-by: Asvin Balloo <[email protected]>
    @kt-12 @asvinb
    kt-12 and asvinb authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e7afe1e View commit details
    Browse the repository at this point in the history

  3. fix e2e

    @kt-12
    kt-12 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    daa483a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/2536-remove-billing' of https://github.com/wooc… 

    …ommerce/google-listings-and-ads into feature/2536-remove-billing
    @kt-12
    kt-12 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    71c81ec View commit details
    Browse the repository at this point in the history

  5. Update js/src/components/paid-ads/ads-campaign.js 

    Co-authored-by: Asvin Balloo <[email protected]>
    @kt-12 @asvinb
    kt-12 and asvinb authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b5a2467 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. clear jest files

    @kt-12
    kt-12 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0ca45f1 View commit details
    Browse the repository at this point in the history

  2. Update js/src/components/paid-ads/ads-campaign.js 

    Co-authored-by: Asvin Balloo <[email protected]>
    @kt-12 @asvinb
    kt-12 and asvinb authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    98cd72d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. conditional enabling continue button

    @kt-12
    kt-12 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    52ca19d View commit details
    Browse the repository at this point in the history

  2. remove file

    @kt-12
    kt-12 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b8178b4 View commit details
    Browse the repository at this point in the history

  3. update disabled button logic

    @kt-12
    kt-12 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c5be7e0 View commit details
    Browse the repository at this point in the history

  4. only to check in setup-ads context

    @kt-12
    kt-12 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1833363 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. fix billing e2e

    @kt-12
    kt-12 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d053b77 View commit details
    Browse the repository at this point in the history

  2. ads campaign request

    @kt-12
    kt-12 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c8ee77f View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. change mock

    @kt-12
    kt-12 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1b31ca9 View commit details
    Browse the repository at this point in the history

  2. move billing page to bottom

    @kt-12
    kt-12 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e7da33a View commit details
    Browse the repository at this point in the history

  3. create a new mock for campaign creation.

    @kt-12
    kt-12 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a6d79a0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/2536-remove-billing' of https://github.com/wooc… 

    …ommerce/google-listings-and-ads into feature/2536-remove-billing
    @kt-12
    kt-12 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7edeb3b View commit details
    Browse the repository at this point in the history

  5. move budget to top.

    @kt-12
    kt-12 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4ff5165 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. e2e cr fixes

    @kt-12
    kt-12 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b90f77c View commit details
    Browse the repository at this point in the history

  2. remove title button component

    @kt-12
    kt-12 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0c6d250 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/2459-campaign-creation-flow' into feature/2536-… 

    …remove-billing
    @joemcgill
    joemcgill committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fdd3aae View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. remove accidently functions

    @kt-12
    kt-12 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    104b368 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. remove newly introduced function

    @kt-12
    kt-12 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2c84851 View commit details
    Browse the repository at this point in the history

  2. Add ContinueButton component.

    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fe7bab6 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. seperate continue button

    @kt-12
    kt-12 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    659f560 View commit details
    Browse the repository at this point in the history

  2. continue button component

    @kt-12
    kt-12 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    836d1a6 View commit details
    Browse the repository at this point in the history

  3. fix continue button logic on edit and create page

    @kt-12
    kt-12 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fdfedba View commit details
    Browse the repository at this point in the history

  4. fix continue button

    @kt-12
    kt-12 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    88ba4e8 View commit details
    Browse the repository at this point in the history

  5. change text

    @kt-12
    kt-12 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c82396b View commit details
    Browse the repository at this point in the history

  6. Omit the billing status check for now

    @joemcgill
    joemcgill committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ed886d8 View commit details
    Browse the repository at this point in the history

  7. Add inline note about the need to update for billing

    @joemcgill
    joemcgill committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    cfd7879 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix review feedback

    @kt-12
    kt-12 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2564a42 View commit details
    Browse the repository at this point in the history

  2. change prop name

    @kt-12
    kt-12 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    dc716ec View commit details
    Browse the repository at this point in the history

  3. handleContinueClick to onClick and return type

    @kt-12
    kt-12 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6b85d4d View commit details
    Browse the repository at this point in the history