Adjust e2e tests for minimum and maximum shipping times #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog: tweak
jorgemd24
changed the base branch from
update/shippings-settings-phase-1
to
update/add-and-edit-shipping-time-inputs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## update/shippings-settings-phase-1 #2619 +/- ##
=================================================================
Coverage 63.8% 63.8%
=================================================================
Files 323 323
Lines 5133 5133
Branches 1257 1257
=================================================================
Hits 3276 3276
Misses 1684 1684
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. |
martynmjones
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Hey @jorgemd24, thanks for updating the e2e tests.
The changes all look good to me and all tests are passing ✅
Base automatically changed from
update/add-and-edit-shipping-time-inputs
to
update/shippings-settings-phase-1
September 24, 2024 08:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Part of pcTzPl-2qP-p2
This PR updates the e2e tests to align with the changes from this PR: #2594
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry