-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Budget setup card updates after merge #2637
Merged
joemcgill
merged 260 commits into
update/2502-budget-setup-card
from
update/2502-budget-setup-card-updates
Oct 2, 2024
Merged
Budget setup card updates after merge #2637
joemcgill
merged 260 commits into
update/2502-budget-setup-card
from
update/2502-budget-setup-card-updates
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed by running `npm run lint:js -- --fix`.
…oesn't support `package.json.exports`.
…merce/currency`.
…nsolidate-ad-creation-ccf-onboarding-merged
…ampaign-creation-flow-2458-merged
…ion-flow-2458-merged 2459 Campaign creation flow and 2458 merged
…creation-ccf-onboarding-merged Merge onboarding improvements branch into consolidated ad
…onsolidate-ad-creation-ccf-merged
…date/2502-budget-setup-card
github-actions
bot
added
the
changelog: update
Big changes to something that wasn't broken.
label
Oct 2, 2024
5 tasks
joemcgill
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. Let's go ahead and merge this and re review the original PR for #2502.
joemcgill
merged commit Oct 2, 2024
f6f7ac3
into
update/2502-budget-setup-card
13 of 18 checks passed
eason9487
added
changelog: none
Skip changelog entry for this PR
and removed
changelog: update
Big changes to something that wasn't broken.
labels
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2502 .
Replace this with a good description of your changes & reasoning.
Additional details:
usFetchBudgetRecommendation
hook from Add minimum budget limit #2583 along with dependencies.Changelog entry