Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Woo.com links to Wooommerce.com #2142

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

danielwrobert
Copy link
Contributor

Updates all instances of woo.com links in both the wp-admin and frontend to point to woocommerce.com. This includes the developer composer and package files, readme, and language files.

This is essentially undoing the work from #2132.

Read full context here: p6q6po-fKm-p2 (internal)

How to test the changes in this Pull Request:

  1. Install and activate Storefront.
  2. Navigate to /wp-admin/themes.php?page=storefront-welcome and check if outbound links point to woocommerce.com instead of woo.com
  3. Navigate to /wp-admin/themes.php?theme=storefront and check if outbound links point to woocommerce.com instead of woo.com
  4. Navigate to the frontend of your website and check that the "Built with Storefront." link navigate to the product page on woocommerce.com correctly.

Changelog

Fix – Updates wp-admin and frontend credit links to point to WooCommerce.com instead of Woo.com

Updates all instances of WooCommerce.com links in both the wp-admin and
frontend. This includes the developer composer and package files, readme,
and language files.
@danielwrobert danielwrobert requested review from thealexandrelara and a team April 10, 2024 19:25
Copy link
Contributor

@thealexandrelara thealexandrelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dan, for working on this! I reviewed the links, and they all reference the WooCommerce.com website correctly. I left a comment about one link that redirects to a different page, but it's not a blocker for this PR, so I'm approving it.

README.txt Outdated

For even more customization, check out Storefront extensions https://woo.com/product-category/storefront-extensions/ and Storefront child themes https://woo.com/product-category/themes/storefront-child-theme-themes/.
For even more customization, check out Storefront extensions https://woocommerce.com/product-category/storefront-extensions/ and Storefront child themes https://woocommerce.com/product-category/themes/storefront-child-theme-themes/.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Storefront child themes link is redirecting to the WooCommerce templates page. I didn't find any reference to a Storefront Child Themes page, only a documentation for it: https://woocommerce.com/documentation/products/themes/storefront/child-themes/

Should we remove this from the documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. It may also make sense to update the link to use the one you've discovered.

I'll push a new commit to update that - it still seems like useful info for folks looking for that kind of thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in e73c7ac.

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Apr 10, 2024
@danielwrobert danielwrobert merged commit 924b80a into trunk Apr 10, 2024
6 checks passed
@danielwrobert danielwrobert deleted the update/url-changes-woo-to-woocommerce branch April 10, 2024 20:26
@thealexandrelara thealexandrelara added this to the 4.5.5 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants