[2 pane layout] Tablet mode detection logic change

[AnirudhBhat]

Closes: #12861

Description

This PR refactors the tablet detection logic to account for both width and height dimensions when determining if a device qualifies as a tablet. The updated logic improves compatibility with larger phones especially in landscape mode.

Changes Introduced:
New Size Class Determination Method:

Introduced determineWindowSizeClassByDimensions(widthDp: Int, heightDp: Int).
Evaluates both shortSize and longSize (smallest and largest dimensions, respectively) to classify devices as Compact, Medium, or ExpandedAndBigger.

Steps to reproduce

1. Open WooCommerce app
2. Navigate to orders screen
3. Rotate your device
4. Observe the Behaviour:
   On smaller devices: The screen remains in single-pane mode and does not split into tablet mode.
   On larger phones and tablets: The screen transitions to split-pane (tablet) mode as expected.

The tests that have been performed

Verified behaviour on below emulators:
Tablets (portrait and landscape)
Large phones in landscape mode

Images/gif

tablet_detection_logic.mp4

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	e0b9d62
	Direct Download	woocommerce-wear-prototype-build-pr13228-e0b9d62.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	e0b9d62
	Direct Download	woocommerce-prototype-build-pr13228-e0b9d62.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 40.64%. Comparing base (3f54acc) to head (e0b9d62).

Files with missing lines	Patch %	Lines
...n/com/woocommerce/android/extensions/ContextExt.kt	0.00%	10 Missing ⚠️

Additional details and impacted files

@@                             Coverage Diff                             @@
##             issue/13221-remove-variation-quantity   #13228      +/-   ##
===========================================================================
- Coverage                                    40.64%   40.64%   -0.01%     
  Complexity                                    6380     6380              
===========================================================================
  Files                                         1349     1349              
  Lines                                        77400    77407       +7     
  Branches                                     10647    10647              
===========================================================================
  Hits                                         31461    31461              
- Misses                                       43159    43166       +7     
  Partials                                      2780     2780              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kidinov]

np: I think this is not a refactoring, but change of the logic

[kidinov]

@AnirudhBhat I think we can not use the same semantics here if we change the logic. Window classes we use here are from https://m3.material.io/foundations/layout/applying-layout/window-size-classes and those are determined based on the width of a device. Reusing the same concept but with different logic may bring confusion and errors

I am thinking that:

• We should either simplify all of this and end up with something "isTwoPaneShouldBeUsed" with logic similar/the same as WooPosIsScreenSizeAllowed. I'd say this is preferred, as I think we learned that the use of those size classes doesn't work well at all
• Or at least refactor all of this and call it in not attaching to the material design size classes name (remove comments etc) to make sure that we don't mix the concepts

wdyt?

[wpmobilebot]

Version 21.4 has now entered code-freeze, so the milestone of this PR has been updated to 21.5.