Skip to content

Commit

Permalink
Merge pull request #459 from woocommerce/dev/npm-dependabot
Browse files Browse the repository at this point in the history
Add npm `^9` as supported engines for dependabot
  • Loading branch information
eason9487 authored Sep 4, 2024
2 parents af3774e + b431de3 commit f6b1063
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ Google Analytics for WooCommerce utilizes npm scripts for task management utilit

`npm run build` - Runs the tasks necessary for a release. These may include building JavaScript, SASS, CSS minification, and language files.

The `engines` in package.json includes npm `^9` to allow dependabot to update our dependencies. However, it's not the version intended to be used in development.

- See https://github.com/dependabot/dependabot-core/issues/9277

## Unit tests
### Running PHP unit tests in your local dev environment
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
},
"engines": {
"node": ">=20",
"npm": ">=10"
"npm": ">=10 || ^9"
},
"config": {
"wp_org_slug": "woocommerce-google-analytics-integration",
Expand Down

0 comments on commit f6b1063

Please sign in to comment.