Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch WC & WP Matrix #290

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Fetch WC & WP Matrix #290

merged 3 commits into from
Aug 17, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Aug 8, 2023

Changes proposed in this Pull Request:

This PR fetch WooCommerce & WP L-2 versions for our tests using https://github.com/woocommerce/grow/tree/trunk/packages/github-actions/actions/get-plugin-releases

Detailed test instructions:

Additional details:

This is based on the approved solution in https://github.com/woocommerce/automatewoo/pull/1527

Changelog entry

Dev - Fetch WooCommerce and WordPress versions for our tests

@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Aug 8, 2023
@puntope puntope requested a review from a team August 9, 2023 14:12
@mikkamp
Copy link
Contributor

mikkamp commented Aug 9, 2023

Just wanted to mention that this comment is also valid for this PR, since it uses the same method for combining WC versions.

@puntope
Copy link
Contributor Author

puntope commented Aug 10, 2023

Just wanted to mention that this comment is also valid for this PR, since it uses the same method for combining WC versions.

I will handle this after validating my solution in https://github.com/woocommerce/automatewoo/pull/1527

@puntope puntope added the status: on hold The issue/PR is currently not prioritized. label Aug 10, 2023
@puntope puntope removed the status: on hold The issue/PR is currently not prioritized. label Aug 16, 2023
@puntope
Copy link
Contributor Author

puntope commented Aug 16, 2023

Hi @mikkamp I update this PR with the approved strategy in https://github.com/woocommerce/automatewoo-referrals/pull/225

This is ready for another round

Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Just making a mental note that we need to check for PHP 8.2 compatibility and run the unit tests with some newer versions of PHP.

@mikkamp mikkamp mentioned this pull request Aug 16, 2023
@puntope puntope merged commit b2742c4 into trunk Aug 17, 2023
3 checks passed
@puntope puntope deleted the dev/wc-wp-matrix branch August 17, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants