Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WordPressCS to version 3.0 #323

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Update WordPressCS to version 3.0 #323

merged 3 commits into from
Oct 31, 2023

Conversation

martynmjones
Copy link
Contributor

Changes proposed in this Pull Request:

Closes #296

Updates WordPressCS to version 3.0 and fixes CS issues across extension files.

Screenshot

Screenshot 2023-10-30 at 11 28 15

Detailed test instructions:

  1. Checkout update/296-update-wordpresscs
  2. Run composer install && npm run lint:php
  3. Confirm no errors are flagged
  4. Review changes

Changelog entry

Update - WordPressCS to version 3.0

@martynmjones martynmjones self-assigned this Oct 30, 2023
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Oct 30, 2023
@martynmjones martynmjones requested a review from a team October 30, 2023 11:33
ianlin
ianlin approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the WPCS version, LGTM.

@martynmjones martynmjones merged commit 29f96e8 into trunk Oct 31, 2023
7 checks passed
@martynmjones martynmjones deleted the update/296-update-wordpresscs branch October 31, 2023 08:29
@ianlin ianlin mentioned this pull request Nov 7, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianlin ianlin ianlin approved these changes

Assignees

@martynmjones martynmjones

Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update WordPressCS to 3.0.0
2 participants
@martynmjones @ianlin