Prevent firing up the add_to_cart event when clicking in product image #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #330
With non-blockified themes, the
add_to_cart
event's selector is quite broad, leading it to trigger even when a user clicks on the product image.woocommerce-google-analytics-integration/includes/class-wc-google-gtag-js.php
Line 225 in 487625e
This PR makes the selector more specific, checking that the link needs to have the class button.
Checks:
Screenshots:
Detailed test instructions:
/wp-admin/admin.php?page=wc-settings&tab=integration§ion=google_analytics
add_to_cart
is not sent.Additional details:
composer require --dev yoast/phpunit-polyfills:"^1.1.0" && composer install
Changelog entry