Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use Node.js 20 and bump npm dependencies #445

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

The end-of-life for Node.js v18 is April 30, 2025, which is still about 10 months away, but there should be no harm in aligning with the same version used in WooCommerce core early!

This PR:

  • Upgrade to use Node.js v20
  • Bump dependencies
    • Add @wordpress/url to dev dependencies as it's no longer a dependency under @wordpress/scripts

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Detailed test instructions:

  1. Set Node.js to v20
  2. Run npm install to see if it can finish without errors
  3. Check if the following scripts work well
    • npm start
    • npm run dev
    • npm run build
    • npm run lint:js
  4. Inspect the E2E test result on GitHub Actions or run it locally to see if all tests can pass

Changelog entry

  • Dev - Upgrade to Node.js 20.
  • Dev - Upgrade npm dependencies.

@eason9487 eason9487 requested a review from a team June 28, 2024 08:43
@eason9487 eason9487 self-assigned this Jun 28, 2024
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Jun 28, 2024
Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eason9487, thanks for the update!

No issues installing packages and all our scripts are working as expected ✅

@eason9487 eason9487 merged commit ba8d8e5 into trunk Jun 28, 2024
3 checks passed
@eason9487 eason9487 deleted the dev/nodejs-20-and-bump-dev-deps branch June 28, 2024 09:35
@eason9487 eason9487 mentioned this pull request Jul 2, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants