Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom fields: Entry point logic in Product Details #14068

Open
wants to merge 21 commits into
base: trunk
Choose a base branch
from
Open

Custom fields: Entry point logic in Product Details #14068

wants to merge 21 commits into from

Commits on Sep 28, 2024

  1. add "show custom fields" functionality on simple products.

    @hafizrahman
    hafizrahman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    a56dcf9 View commit details
    Browse the repository at this point in the history

  2. Update logic for showing the Custom Fields option in Product details. 

    - If product already has custom fields, show it in the settings row.
- If not, show it in "Add more details" action bottom sheet instead.
    @hafizrahman
    hafizrahman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3999821 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Move Custom Fields to the end for simple product actions.

    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1092e0f View commit details
    Browse the repository at this point in the history

  2. Add Custom Fields option to all other type of products.

    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    61836a2 View commit details
    Browse the repository at this point in the history

  3. Add logic to hide custom fields option when creating new product.

    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    72b669f View commit details
    Browse the repository at this point in the history

  4. Update custom fields option icon.

    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    9b6ffbc View commit details
    Browse the repository at this point in the history

  5. Add visibility unit tests for custom fields option.

    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    6fdc39d View commit details
    Browse the repository at this point in the history

  6. Refactor to pass FeatureFlagService to the factory so that it's testa… 

    …ble.
    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    cd64bbc View commit details
    Browse the repository at this point in the history

  7. Update visibility tests to include feature flag

    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    7076bde View commit details
    Browse the repository at this point in the history

  8. Refactor add new product case checking by using formType instead.

    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f6f1c33 View commit details
    Browse the repository at this point in the history

  9. Move custom fields test about creation to ProductCreationTests

    @hafizrahman
    hafizrahman committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    d6dcaf3 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Update unit tests with extra checks.

    @hafizrahman
    hafizrahman committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c1d5a44 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Various design updates to make the navigation change to/from custom f… 

    …ields list look smoother.
    @hafizrahman
    hafizrahman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    cfd6c47 View commit details
    Browse the repository at this point in the history

  2. Update test names

    @hafizrahman
    hafizrahman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1803039 View commit details
    Browse the repository at this point in the history

  3. For custom fields visibility tests, loop through the entire product t… 

    …ypes.
    @hafizrahman
    hafizrahman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a8639e4 View commit details
    Browse the repository at this point in the history

  4. Update requirement to only show custom fields row in product details … 

    …during .edit, and not in .add or .readonly mode.
    @hafizrahman
    hafizrahman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    722f978 View commit details
    Browse the repository at this point in the history

  5. Add product details readonly tests related to custom fields row.

    @hafizrahman
    hafizrahman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3b45405 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Fix strings for custom fields row title and subtitle

    @hafizrahman
    hafizrahman committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    aa0ccd5 View commit details
    Browse the repository at this point in the history

  2. Keep animation on push case.

    @hafizrahman
    hafizrahman committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d513b54 View commit details
    Browse the repository at this point in the history

  3. Move CaseIterable conformance into unit test instead.

    @hafizrahman
    hafizrahman committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    fa038ce View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into feat/14067-show-custom-fields-product-details

    @hafizrahman
    hafizrahman authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    fbcabcd View commit details
    Browse the repository at this point in the history