Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping Labels] Use failsafeDecodeIfPresent for decoding package weight #14753

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

bozidarsevo
Copy link
Contributor

@bozidarsevo bozidarsevo commented Dec 23, 2024

Closes: #14751

Description

Testing information

  1. Install and set up the Woo Shipping extension on your store.
  2. Build and run the app with the revampedShippingLabelCreation feature flag enabled.
  3. Create an order with the processing status and at least one physical product.
  4. In your WooCommerce product settings on the web, change the weight and dimension units and save your changes.
  5. On the Orders tab in the app, open the order you created.
  6. In the order details, select "Create Shipping Label."
  7. Tap "Select a Package."
  8. Switch to Carrier and Saved tabs and check that the packages are loaded and showing correct data
  9. Switch to Custom tab
  10. Fill in all the values for the package, including weight and name and tap "Add Package"
  11. Check that on the Create Shipping Labels screen the newly created package is shown, with proper name, dimensions and weight

Screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-23.at.11.13.17.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@bozidarsevo bozidarsevo added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Dec 23, 2024
@bozidarsevo bozidarsevo added this to the 21.4 milestone Dec 23, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 23, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14753-4c3f659
Version21.3
Bundle IDcom.automattic.alpha.woocommerce
Commit4c3f659
App Center BuildWooCommerce - Prototype Builds #12277
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@bozidarsevo bozidarsevo marked this pull request as ready for review December 23, 2024 11:29
@@ -11,7 +11,7 @@
"id": "69d7052f934a7c218329de9c1abe3858",
"name": "WCS&T Box",
"dimensions": "15 x 15 x 15",
"box_weight": 0.25,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it so response example has both box_weight and boxWeight

@bozidarsevo bozidarsevo changed the title Use failsafeDecodeIfPresent for decoding package weight [Shipping Labels] Use failsafeDecodeIfPresent for decoding package weight Dec 23, 2024
@bozidarsevo bozidarsevo requested a review from toupper December 24, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use failsafeDecodeIfPresent for decoding package weight
2 participants