Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brand Updates] POS theme updates #14756

Open
wants to merge 3 commits into
base: feature/woo-2.0-brand-updates
Choose a base branch
from

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Dec 23, 2024

Part of: woocommerce/woomobile-private#382

Description

This PR updates the POS theme colors to match the new brand, it introduces a new accent color that uses purple_40 in light theme and purple_30 in dark theme, and updates the different components to use it.

Note: If we are worried this update might break something, I'm fine with dropping it of the project.

Steps to reproduce

  1. Use a tablet.
  2. Open the More menu, and tap on "Point of Sale mode"
  3. Check different screens on different themes.

Testing information

  • Confirm the new colors matches the new brand.

Tested using iPad Air simulator, iOS 18.1

Screenshots

Before After
Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 22 43 Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 20 46
Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 22 47 Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 20 52
Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 22 51 Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 20 57
Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 01 20 Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 12 59 42
Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 01 27 Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 19 11
Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 01 31 Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 19 20

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@hichamboushaba hichamboushaba added type: enhancement A request for an enhancement. category: design Layout and style elements in the UI or user interface, including color and animations. feature: POS labels Dec 23, 2024
@hichamboushaba hichamboushaba changed the title Task/woo 2.0 pos theme changes [Brand Updates] POS theme updates Dec 23, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 23, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14756-65b865c
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit65b865c
App Center BuildWooCommerce - Prototype Builds #12281
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

)
)
}
static var posPrimaryButtonBackground: Color = .accent
Copy link
Member Author

@hichamboushaba hichamboushaba Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the regular app theme, the primary button uses purple_40 in all themes, this is to give a better contrast with the white text (more context here p1734705352565459/1727138732.960149-slack-C07E7D0R761), but for POS, I noticed the button text is black, so for now, it will use purple_30 in dark theme.

Was the usage of black text here a design decision or just a dev choice? Personally, I think white looks better and gives a better contrast, but that's just a thought.

Black White
Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 13 19 11 Simulator Screenshot - iPad Air 13-inch (M2) - 2024-12-23 at 12 56 17

)
)
}
static var posSecondaryButtonForeground: Color = .accent
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The POSSecondaryButtonStyle was referencing posPrimaryButtonBackground. When I first changed posPrimaryButtonBackground to use a single color for both themes, I added this property. However, I later modified the primary button background again (see the comment above), so this property isn't strictly necessary now. Still, in my opinion, retaining it could enhance clarity and help decouple the components. Let me know your thoughts.

@hichamboushaba hichamboushaba marked this pull request as ready for review December 23, 2024 12:38
@@ -17,7 +17,7 @@ struct POSProgressViewStyle: ProgressViewStyle {
lineWidth: lineWidth,
lineCap: .butt,
circleColor: Color(.wooCommercePurple(.shade10)),
fillColor: Color(.wooCommercePurple(.shade50))
fillColor: Color.accent
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this to match the updated app accent, which is purple_40 in light theme and purple_30 in dark theme.
This matches the color we use in the last Figma playground files (rNAclWFAdQRw7EXEcsNVai-fi-2533_5542) where we are are using purple_40 on light theme.

@hichamboushaba hichamboushaba added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Dec 23, 2024
@staskus
Copy link
Collaborator

staskus commented Dec 23, 2024

Thanks, @hichamboushaba for the changes! We'll make sure we're aligned with the decisions before merging. Feel free to leave it for us to finish & merge.

Base automatically changed from task/woo-2.0-dark-theme-updates to feature/woo-2.0-brand-updates December 24, 2024 07:31
@hichamboushaba hichamboushaba removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations. feature: POS type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants