Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused surveys for order creation and product creation #14892

Open
wants to merge 5 commits into
base: task/14529-remove-coupon-survey
Choose a base branch
from

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 16, 2025

Closes: #14529

Description

This PR removes unused feedback survey-related code for order creation and product creation.

Steps to reproduce

This PR only removes unused code so no user-interface changes can be tested. You can smoke test the product list to confirm that it works as before.

Testing information

Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the product list still work as before.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: order list Related to the order list. feature: product list Related to the product list. labels Jan 16, 2025
@itsmeichigo itsmeichigo added this to the 21.5 milestone Jan 16, 2025
@itsmeichigo itsmeichigo changed the title Task/14529 remove unused survey code Remove unused surveys for order creation and product creation Jan 16, 2025
@itsmeichigo itsmeichigo removed the feature: order list Related to the order list. label Jan 16, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review January 16, 2025 05:20
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14892-8475628
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commit8475628
App Center BuildWooCommerce - Prototype Builds #12556
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product list Related to the product list. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants