Move icons to constants

woocommerce · Dec 23, 2024 · a78e11c · a78e11c
1 parent eeb0c63
commit a78e11c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/modules/ppcp-settings/resources/js/Components/ReusableComponents/Icons.js b/modules/ppcp-settings/resources/js/Components/ReusableComponents/Icons.js
@@ -1 +1,3 @@
 export { default as openSignup } from './Icons/open-signup';
+export const NOTIFICATION_SUCCESS = '✔️';
+export const NOTIFICATION_ERROR = '❌';
diff --git a/...omponents/Screens/Overview/TabSettingsElements/Blocks/Troubleshooting/ResubscribeBlock.js b/...omponents/Screens/Overview/TabSettingsElements/Blocks/Troubleshooting/ResubscribeBlock.js
@@ -4,6 +4,10 @@ import { ButtonSettingsBlock } from '../../../../../ReusableComponents/SettingsB
 import { __ } from '@wordpress/i18n';
 import { useDispatch } from '@wordpress/data';
 import { store as noticesStore } from '@wordpress/notices';
+import {
+	NOTIFICATION_ERROR,
+	NOTIFICATION_SUCCESS,
+} from '../../../../../ReusableComponents/Icons';
 
 const ResubscribeBlock = () => {
 	const { createSuccessNotice, createErrorNotice } =
@@ -24,7 +28,7 @@ const ResubscribeBlock = () => {
 					'woocommerce-paypal-payments'
 				),
 				{
-					icon: '❌',
+					icon: NOTIFICATION_ERROR,
 				}
 			);
 			return;
@@ -37,7 +41,7 @@ const ResubscribeBlock = () => {
 				'woocommerce-paypal-payments'
 			),
 			{
-				icon: '✔️',
+				icon: NOTIFICATION_SUCCESS,
 			}
 		);
 	};

diff --git a/...Components/Screens/Overview/TabSettingsElements/Blocks/Troubleshooting/SimulationBlock.js b/...Components/Screens/Overview/TabSettingsElements/Blocks/Troubleshooting/SimulationBlock.js
@@ -4,6 +4,10 @@ import { ButtonSettingsBlock } from '../../../../../ReusableComponents/SettingsB
 import { useDispatch } from '@wordpress/data';
 import { store as noticesStore } from '@wordpress/notices';
 import { CommonHooks } from '../../../../../../data';
+import {
+	NOTIFICATION_ERROR,
+	NOTIFICATION_SUCCESS,
+} from '../../../../../ReusableComponents/Icons';
 
 const SimulationBlock = () => {
 	const {
@@ -52,7 +56,7 @@ const SimulationBlock = () => {
 					'woocommerce-paypal-payments'
 				),
 				{
-					icon: '❌',
+					icon: NOTIFICATION_ERROR,
 				}
 			);
 			return;
@@ -78,7 +82,7 @@ const SimulationBlock = () => {
 							'woocommerce-paypal-payments'
 						),
 						{
-							icon: '✔️',
+							icon: NOTIFICATION_SUCCESS,
 						}
 					);
 					stopSimulation();
@@ -97,7 +101,7 @@ const SimulationBlock = () => {
 				'woocommerce-paypal-payments'
 			),
 			{
-				icon: '❌',
+				icon: NOTIFICATION_ERROR,
 			}
 		);
 	};