Merge pull request #556 from woocommerce/PCP-604-paypal-button-missin…

…g-on-pay-for Move up pay order render button before checking empty cart
woocommerce · Mar 28, 2022 · d6286ec · d6286ec
2 parents e088d3c + d8e1b09
commit d6286ec
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog.txt b/changelog.txt
@@ -7,6 +7,9 @@
 * Fix - Incorrect TAX details on PayPal order overview #541
 * Fix - "Place order" button looking unstyled in the Twenty Twenty-Two theme #478
 * Fix - PayPal options available on minicart when adding subscription to the cart from shop page without vaulting enabled #518
+* Fix - Buttons not visible on products page #551
+* Fix - Buttons not visible in mini-cart #553
+* Fix - PayPal button missing on pay for order page #555
 * Enhancement - PayPal buttons loading time #533
 * Enhancement - Improve payment token checking for subscriptions #525
 * Enhancement - Add Spain and Italy to messaging #497

diff --git a/modules/ppcp-button/src/Assets/SmartButton.php b/modules/ppcp-button/src/Assets/SmartButton.php
@@ -352,6 +352,8 @@ private function render_button_wrapper_registrar(): bool {
 			);
 		}
 
+		add_action( $this->pay_order_renderer_hook(), array( $this, 'button_renderer' ), 10 );
+
 		if ( $this->is_cart_price_total_zero() ) {
 			return false;
 		}
@@ -390,7 +392,6 @@ class="woocommerce-mini-cart__buttons buttons"
 		}
 
 		add_action( $this->checkout_button_renderer_hook(), array( $this, 'button_renderer' ), 10 );
-		add_action( $this->pay_order_renderer_hook(), array( $this, 'button_renderer' ), 10 );
 
 		return true;
 	}

diff --git a/readme.txt b/readme.txt
@@ -88,6 +88,9 @@ Follow the steps below to connect the plugin to your PayPal account:
 * Fix - Incorrect TAX details on PayPal order overview #541
 * Fix - "Place order" button looking unstyled in the Twenty Twenty-Two theme #478
 * Fix - PayPal options available on minicart when adding subscription to the cart from shop page without vaulting enabled #518
+* Fix - Buttons not visible on products page #551
+* Fix - Buttons not visible in mini-cart #553
+* Fix - PayPal button missing on pay for order page #555
 * Enhancement - PayPal buttons loading time #533
 * Enhancement - Improve payment token checking for subscriptions #525
 * Enhancement - Add Spain and Italy to messaging #497