Apple Pay recurring payments (2521) #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/ppcp-save-payment-methods/src/SavePaymentMethodsModule.php
Dinamiko
approved these changes
Jan 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds support for
ApplePayvaulting.It ensures that
ApplePayvaulted tokens, as per Apple policies, cannot be used to pay orders of returning users and only to renew subscriptions.The PR refactors
ApplePayandVenmouse their own dedicated payment token classes:PaymentTokenVenmo, PaymentTokenApplePay. This allows for better code interpretation and isolation.PayPalandVenmovaulting generate by default the samevault.id, which causes an issue where the token is only valid for the first payment_source that does a merchant initiated payment, and will fail if we try with the otherpayment_source(error:MISMATCHED_VAULT_ID_TO_PAYMENT_SOURCE).To resolve this PayPal suggests setting the
permit_multiple_payment_tokens=true.This PR implements this suggestion so now a different
vault.idis generated per vaulting request.https://developer.paypal.com/docs/checkout/save-payment-methods/during-purchase/js-sdk/venmo/
Issue Description
Add support for saving Apple Pay payment methods (when using Vault v3).
https://developer.paypal.com/docs/checkout/save-payment-methods/during-purchase/js-sdk/applepay/
Note: Apple Pay can't be used as a payment method for returning buyers, according to Apple guidelines.
This means saved Apple Pay payments will only be available as a payment method for subscription renewal payments, not for return-buyer checkouts.
We should ensure that buyers are not able to use a saved Apple Pay payment method for a return purchase on the Block Checkout, while still bing able to switch the payment method on existing subscriptions to the saved Apple Pay payment method.
Acceptance
Given a subscription product is in the cart (or on single product)
When using Apple Pay as a payment method
Then Apple Pay payment method gets saved
And can be used only for subscription renewal payments