New Settings UI: Disable settings in send-only countries (4027) #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stracker-phil I wasn’t sure if there is a specific style we need to use for notices, so I haven’t added any styling for the notice yet, just plain text. |
There was a problem hiding this comment.
We should translate this message via __() or inject the string from server-side using wp_localize_script()
There was a problem hiding this comment.
Hi @stracker-phil, I added localization to the message in my latest commit 👍🏻
stracker-phil
requested changes
Dec 20, 2024
hmouhtar
force-pushed
the
PCP-4027-send-only-settings
branch
from
f92c868 to
58863ff
Compare
hmouhtar
force-pushed
the
PCP-4027-send-only-settings
branch
from
58863ff to
9278edf
Compare
stracker-phil
requested changes
Jan 8, 2025
| @@ -68,8 +69,9 @@ static function () use ( $c ) { | |||
| $current_page_id = $c->get( 'wcgateway.current-ppcp-settings-page-id' ); | |||
| $is_wc_settings_page = $c->get( 'wcgateway.is-wc-settings-page' ); | |||
| $messaging_locations = $c->get( 'paylater-configurator.messaging-locations' ); | |||
| $onboarding_state = $c->get( 'onboarding.state' ); | |||
There was a problem hiding this comment.
This uses the legacy onboarding status.
To check if the onboarding in the new UI is completed, you can use this logic:
$onboarding_profile = $c->get( 'settings.data.onboarding' );
$onboarding_profile->get_completed(); // true = onboarding is done, false = still in the onboarding wizardThere was a problem hiding this comment.
Hi @stracker-phil, I've switched to the new onboarding profile class on my latest commit 👍🏻
# Conflicts: # modules/ppcp-settings/src/Data/CommonSettings.php # modules/ppcp-settings/src/Endpoint/CommonRestEndpoint.php
Before this change, the settings screen was briefly visible, before the merchant details were loaded from the REST endpoint
stracker-phil
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the settings screen to hide all settings if the store's current country is classified as a send-only country. Instead, a message explaining this limitation will be displayed.
Steps to Test
Screenshots