Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode tailwind extensions & prettier tailwind linter, sort tailwind classes #4622

Merged
merged 18 commits into from
Dec 31, 2024

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Dec 26, 2024

These are the ones that cause the auto-sorting in all my recent PRs. If we would all use these (and sort all classes once), we'd have a predictable and consistent order of tailwind classes.

  • Added prettier checks to docs/ and web/ enforcing the sorting. As the release process in plugin-prettier has some issues currently, I've used :next to move on

@pat-s pat-s added skip-changelog build CI pipeline related labels Dec 26, 2024
@xoxys
Copy link
Member

xoxys commented Dec 26, 2024

Can we add linting as well then? Not everybody uses VSCode.

@pat-s pat-s changed the title Add vscode tailwind extensions Add vscode tailwind extensions & prettier tailwind linter, sort tailwind classes Dec 26, 2024
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Dec 26, 2024

Deployment of preview was torn down

@pat-s
Copy link
Contributor Author

pat-s commented Dec 26, 2024

@pat-s pat-s marked this pull request as draft December 26, 2024 22:39
web/.prettierrc.js Outdated Show resolved Hide resolved
.gitpod.yml Outdated Show resolved Hide resolved
.prettierrc.json Outdated Show resolved Hide resolved
@pat-s pat-s marked this pull request as ready for review December 29, 2024 14:40
@pat-s pat-s marked this pull request as draft December 29, 2024 14:43
@pat-s pat-s force-pushed the chore/tailwind-extensions branch from 7693e71 to f80dcc1 Compare December 29, 2024 14:56
@pat-s pat-s force-pushed the chore/tailwind-extensions branch from f80dcc1 to 658ece1 Compare December 29, 2024 15:05
@pat-s pat-s marked this pull request as ready for review December 31, 2024 11:40
@pat-s pat-s merged commit 5b0d788 into main Dec 31, 2024
7 checks passed
@pat-s pat-s deleted the chore/tailwind-extensions branch December 31, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI pipeline related skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants